Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frontend lint / tests to ci workflow #655

Merged
merged 4 commits into from
Jul 2, 2023
Merged

Add frontend lint / tests to ci workflow #655

merged 4 commits into from
Jul 2, 2023

Conversation

acrantel
Copy link
Member

@acrantel acrantel commented Jun 27, 2023 •
edited
Loading

makes frontend2 tests / linting run on each pr.

@acrantel acrantel changed the base branch from main to frontend2 June 27, 2023 23:46
lowtorola
lowtorola previously approved these changes Jun 28, 2023
View reviewed changes
n8kim1
n8kim1 previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@n8kim1 n8kim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice to have

@n8kim1
Copy link
Contributor

n8kim1 commented Jun 28, 2023

do we ever plan on renaming frontend2 to frontend and then frontend to "old" or smth? if so, we'll have to make careful note to change this folder too, cuz it's not really a directory name in the same way in code as everything else

to be fair, i think that errors will expose this too

j-mao
j-mao reviewed Jun 28, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
run: cd frontend2 && npm install
- name: Check linting and formatting
# Custom script for checking the linting and formatting being in place
run: cd frontend2 && npm run lint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the working-directory key in the example here.

@j-mao
Copy link
Member

j-mao commented Jun 28, 2023

GitHub workflow looks good to me! [modulo nit about using working-directory instead of cd blah &&] Thanks so much for doing this 🎉

do we ever plan on renaming frontend2 to frontend and then frontend to "old" or smth? if so, we'll have to make careful note to change this folder too, cuz it's not really a directory name in the same way in code as everything else

This can be done already, can't it? If I understand correctly this branch has zero dependency on the contents of frontend so the old stuff can be safely dropped and this directory renamed on the branch. Whenever you need to peek at old stuff, you can still find it in version control on main until this big feature branch gets merged.

@acrantel
Copy link
Member Author

GitHub workflow looks good to me! [modulo nit about using working-directory instead of cd blah &&] Thanks so much for doing this 🎉

do we ever plan on renaming frontend2 to frontend and then frontend to "old" or smth? if so, we'll have to make careful note to change this folder too, cuz it's not really a directory name in the same way in code as everything else

This can be done already, can't it? If I understand correctly this branch has zero dependency on the contents of frontend so the old stuff can be safely dropped and this directory renamed on the branch. Whenever you need to peek at old stuff, you can still find it in version control on main until this big feature branch gets merged.

will put this into our roadmap

@acrantel acrantel changed the base branch from frontend2 to main June 28, 2023 22:21
@acrantel acrantel dismissed stale reviews from n8kim1 and lowtorola June 28, 2023 22:21

The base branch was changed.

@acrantel acrantel changed the base branch from main to frontend2 June 28, 2023 22:25
@acrantel
Copy link
Member Author

added a recommended plugin to eslint and required semicolons.

@acrantel acrantel merged commit 4bf48ac into frontend2 Jul 2, 2023
@acrantel acrantel deleted the serena/ci branch July 2, 2023 18:58
acrantel added a commit that referenced this pull request Aug 15, 2023
@acrantel
Add frontend lint / tests to ci workflow (#655)
796848e
acrantel added a commit that referenced this pull request Aug 15, 2023
@acrantel
Add frontend lint / tests to ci workflow (#655)
3e9b7ef
acrantel added a commit that referenced this pull request Oct 3, 2023
@acrantel
Add frontend lint / tests to ci workflow (#655)
43f17c0
acrantel added a commit that referenced this pull request Feb 8, 2024
@acrantel
Add frontend lint / tests to ci workflow (#655)
db0b68d
acrantel added a commit that referenced this pull request Feb 8, 2024
@acrantel
Add frontend lint / tests to ci workflow (#655)
73f986b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n8kim1 n8kim1 n8kim1 approved these changes

@apollo1291 apollo1291 Awaiting requested review from apollo1291

@j-mao j-mao Awaiting requested review from j-mao

@lowtorola lowtorola Awaiting requested review from lowtorola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acrantel @n8kim1 @j-mao @lowtorola